Fix table rate failing for zip+4 address #17770 #18166
Conversation
|
|
|
Hi @magently. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
| @@ -51,7 +52,7 @@ public function prepareSelect(\Magento\Framework\DB\Select $select) | |||
| "dest_country_id = '0' AND dest_region_id = 0 AND dest_zip = '*'", | |||
| "dest_country_id = :country_id AND dest_region_id = 0 AND dest_zip = ''", | |||
| "dest_country_id = :country_id AND dest_region_id = 0 AND dest_zip = :postcode", | |||
| "dest_country_id = :country_id AND dest_region_id = 0 AND dest_zip = '*'" | |||
There was a problem hiding this comment.
I am wondering why did you remove the line with the star?
There was a problem hiding this comment.
If you look at lines 49 and 54 in original code, you will see that there were two identical conditions in this OR statement. So we removed one.
There was a problem hiding this comment.
@magently yes, I missed that. You are right
| * or the part of it prior to the dash in the other case | ||
| * @return string | ||
| */ | ||
| public function getDestPostcodePrefix() |
There was a problem hiding this comment.
I see no reason to make this method public. Do you?
magently
force-pushed
the
fix/extended-zip-code-in-table-rates
branch
from
381e9de to
6e4a4b2
Compare
|
Hi @slavvka, thank you for the review. |
|
Hi @magently. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Description
Currently when a customer uses an American ZIP+4 postcode, the table rate shipping method fails to return a quote.
Fixed Issues (if relevant)
Manual testing scenarios
Country,Region/State,Zip/Postal Code,Weight (and above),Shipping PriceUSA,*,12345,1,2Expected result
Actual result
The issue is now fixed. If the customer uses a ZIP+4 code (ex: 12345-1234) in case a rate for an exact match (12345-1234) is not found in the table there will be a fallback check for 12345.
Contribution checklist