Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Fix table rate failing for zip+4 address #17770 #18499

Conversation

gelanivishal
Copy link
Contributor

@gelanivishal gelanivishal commented Oct 10, 2018

Original Pull Request

#18166

Description

Currently when a customer uses an American ZIP+4 postcode, the table rate shipping method fails to return a quote.

Fixed Issues (if relevant)

  1. Table rate fail when using ZIP+4 shipping address #17770

Manual testing scenarios

  1. Create a Product with weight >= 1.
  2. Enable the Table shipping rate
  3. Import the rate CSV file:
    Country,Region/State,Zip/Postal Code,Weight (and above),Shipping Price
    USA,*,12345,1,2
  4. Create a customer on the frontend with a zip code in the format ZIP+4 (ex: 12345-1234).
  5. Add Product to your cart
  6. Go to checkout

Expected result

  1. The table rate shipping method should ignore the extension and appear with a 2$ shipping fee.

Actual result

  1. The table rate shipping is not present.

The issue is now fixed. If the customer uses a ZIP+4 code (ex: 12345-1234) in case a rate for an exact match (12345-1234) is not found in the table there will be a fallback check for 12345.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3142 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants