-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix category tree in cart price rule #17493 #18175
Fix category tree in cart price rule #17493 #18175
Conversation
Hi @magently. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @magently, we need the fix to be delivered also to 2.3-develop branch so please don't forget to port this PR to 2.3-develop; you can do it easily using the Porting Tool, https://devdocs.magento.com/guides/v2.2/contributor-guide/contributing.html#porting-tool |
Sure. We will port it as soon as this PR gets merged. |
Hi @magently. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Description
Currently if you try to create a catalog price rule based on categories with nesting level 4 or higher (1 being the Default Category), these categories (despite being correctly saved in the condition) won't have their corresponding checkboxes checked when you open the Category Chooser again.
Fixed Issues (if relevant)
Manual testing scenarios
that only categories with level <= 3 are selected
and category with level > 3 without selection
Point 5 is now fixed. All the previously chosen categories have their corresponding checkboxes checked after reopening Category Chooser.
Contribution checklist