Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix category tree in cart price rule #17493 #18175

Conversation

magently
Copy link

@magently magently commented Sep 21, 2018

Description

Currently if you try to create a catalog price rule based on categories with nesting level 4 or higher (1 being the Default Category), these categories (despite being correctly saved in the condition) won't have their corresponding checkboxes checked when you open the Category Chooser again.

Fixed Issues (if relevant)

  1. Catalog Rule & Selected Categories with level > 3 #17493

Manual testing scenarios

  1. Open form for creating a new Catalog Rule
  2. Under Condition select Product Attribute -> Category
  3. Open Category Chooser
  4. Select one Category with level = 1, 2 or 3
  5. Select at least one Category with level > 3 (4, 5, ...)
  6. Click ok & close Category Chooser
  7. Open again Category Chooser and see
    that only categories with level <= 3 are selected
    and category with level > 3 without selection

Point 5 is now fixed. All the previously chosen categories have their corresponding checkboxes checked after reopening Category Chooser.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @magently. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@slavvka
Copy link
Member

slavvka commented Sep 26, 2018

Hi @magently, we need the fix to be delivered also to 2.3-develop branch so please don't forget to port this PR to 2.3-develop; you can do it easily using the Porting Tool, https://devdocs.magento.com/guides/v2.2/contributor-guide/contributing.html#porting-tool

@magently
Copy link
Author

Hi @magently, we need the fix to be delivered also to 2.3-develop branch so please don't forget to port this PR to 2.3-develop; you can do it easily using the Porting Tool, https://devdocs.magento.com/guides/v2.2/contributor-guide/contributing.html#porting-tool

Sure. We will port it as soon as this PR gets merged.

@magento-engcom-team
Copy link
Contributor

Hi @magently. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@magently magently deleted the fix/catalog-rule-categories-selection branch August 9, 2019 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants