Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Fix category tree in cart price rule #17493 #18500

Conversation

gelanivishal
Copy link
Contributor

@gelanivishal gelanivishal commented Oct 10, 2018

Original Pull Request

#18175

Description

Currently if you try to create a catalog price rule based on categories with nesting level 4 or higher (1 being the Default Category), these categories (despite being correctly saved in the condition) won't have their corresponding checkboxes checked when you open the Category Chooser again.

Fixed Issues (if relevant)

  1. Catalog Rule & Selected Categories with level > 3 #17493

Manual testing scenarios

  1. Open form for creating a new Catalog Rule
  2. Under Condition select Product Attribute -> Category
  3. Open Category Chooser
  4. Select one Category with level = 1, 2 or 3
  5. Select at least one Category with level > 3 (4, 5, ...)
  6. Click ok & close Category Chooser
  7. Open again Category Chooser and see
    that only categories with level <= 3 are selected
    and category with level > 3 without selection

Point 5 is now fixed. All the previously chosen categories have their corresponding checkboxes checked after reopening Category Chooser.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3143 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants