Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed value of columns not updating in ui_bookmark table #18558

Closed
wants to merge 1 commit into from

Conversation

gelanivishal
Copy link
Contributor

Description (*)

There was data type issue in ui_bookmark table.

Fixed Issues (if relevant)

  1. Value of created_at and updated_at columns not updating in ui_bookmark table #18557: Value of created_at and updated_at columns not updating in ui_bookmark table

Manual testing scenarios (*)

  1. Check phpmyadmin and go to ui_bookmark table

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@slavvka slavvka self-assigned this Oct 18, 2018
@slavvka
Copy link
Member

slavvka commented Oct 18, 2018

hey @gelanivishal Thank you for the contribution but such a change is backward incompatible (look https://devdocs.magento.com/guides/v2.2/contributor-guide/backward-compatible-development/#db-schema). Also this solution doesn't work for existing installations. Please consider creating you PR to 2.3 where Declarative Scheme was introduced (https://devdocs.magento.com/guides/v2.3/extension-dev-guide/declarative-schema/)

@slavvka slavvka closed this Oct 18, 2018
@gelanivishal
Copy link
Contributor Author

@slavvka Check new PR #18699 for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants