-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed value of columns not updating in ui_bookmark table #18699
Conversation
Hi @gelanivishal. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@gelanivishal Thank you for the changes. We want all PRs to be delivered to 2.3 and than backported to 2.2. Could you please port it to 2.3 and then we will accept this one? Please pay your attention that we introduced Declarative Schema in 2.3 so you need to implement the fix in different way for 2.3. Please refer to the guide |
@slavvka GREAT!! You can tell me at once comment. I have to create 3 PR for the same issue. |
@gelanivishal Sorry but we need to make sure that changes in 2.2 will exist in 2.3 as well to maintain cross-versioned integrity. Does it make sense? |
Hi @gelanivishal , I am closing this PR now due to inactivity. |
@sidolov Please check changes. Magento 2.3 and 2.2 don't have same changes. |
Hey @gelanivishal. This PR was closed due to inactivity. Please fell free to proceed with this PR once you port it to 2.3 |
@slavvka It's already open. Can you please review my changes? |
Hey @gelanivishal. This PR is fine. But we want to have all PRs to be delivered to 2.3 firstly. Please create a upport to 2.3 and we will process it. I already mentioned before how to create PRs to 2.3 since there was introduced the declarative schema. thank you! |
Hey @gelanivishal I am closing this PR due to inactivity. Please feel free to re-open it once you up-port it to 2.3 (with appropriate approach). Thank you! |
Description (*)
There was data type issue in ui_bookmark table.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)