Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed value of columns not updating in ui_bookmark table #18699

Closed
wants to merge 2 commits into from

Conversation

gelanivishal
Copy link
Contributor

Description (*)

There was data type issue in ui_bookmark table.

Fixed Issues (if relevant)

  1. Value of created_at and updated_at columns not updating in ui_bookmark table #18557: Value of created_at and updated_at columns not updating in ui_bookmark table

Manual testing scenarios (*)

  1. Check phpmyadmin and go to ui_bookmark table

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@slavvka
Copy link
Member

slavvka commented Oct 22, 2018

@gelanivishal Thank you for the changes. We want all PRs to be delivered to 2.3 and than backported to 2.2. Could you please port it to 2.3 and then we will accept this one? Please pay your attention that we introduced Declarative Schema in 2.3 so you need to implement the fix in different way for 2.3. Please refer to the guide

@gelanivishal
Copy link
Contributor Author

@slavvka GREAT!! You can tell me at once comment. I have to create 3 PR for the same issue.

@slavvka
Copy link
Member

slavvka commented Oct 23, 2018

@gelanivishal Sorry but we need to make sure that changes in 2.2 will exist in 2.3 as well to maintain cross-versioned integrity. Does it make sense?

@sidolov
Copy link
Contributor

sidolov commented Nov 5, 2018

Hi @gelanivishal , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Nov 5, 2018
@gelanivishal gelanivishal reopened this Nov 16, 2018
@gelanivishal
Copy link
Contributor Author

@sidolov Please check changes. Magento 2.3 and 2.2 don't have same changes.

@slavvka
Copy link
Member

slavvka commented Nov 16, 2018

Hey @gelanivishal. This PR was closed due to inactivity. Please fell free to proceed with this PR once you port it to 2.3

@gelanivishal
Copy link
Contributor Author

@slavvka It's already open. Can you please review my changes?

@slavvka
Copy link
Member

slavvka commented Nov 17, 2018

Hey @gelanivishal. This PR is fine. But we want to have all PRs to be delivered to 2.3 firstly. Please create a upport to 2.3 and we will process it. I already mentioned before how to create PRs to 2.3 since there was introduced the declarative schema. thank you!

@slavvka
Copy link
Member

slavvka commented Dec 4, 2018

Hey @gelanivishal I am closing this PR due to inactivity. Please feel free to re-open it once you up-port it to 2.3 (with appropriate approach). Thank you!

@slavvka slavvka closed this Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants