Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference pull request of #18604 for 2.3-develop #18631

Merged

Conversation

mahesh-rajawat
Copy link
Member

@mahesh-rajawat mahesh-rajawat commented Oct 15, 2018

Fixed issue of product with a special price of 0.00, this is not shown on the frontend. Not in the product listings and also not on the product detail page.

Description (*)

Product Special Price is set to 0 then its not visible on product listing and Product View page, but when
we add product in cart, its price added to 0 in cart. In this pull request i have fixed this issue, now
Special price is displaying 0 as well.

Fixed Issues (if relevant)

  1. M2.2.6 : Special price of 0.0000 is not shown on frontend, but is calculated in cart #18268: Special price of 0.0000 is not shown on frontend, but is calculated in car

Manual testing scenarios (*)

  1. Created new product and set the special price 0 and saved it.
  2. Open product in category page special price is displaying 0 as normal.
  3. Open product in product view page special price is displaying 0.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Port for: #18604

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 15, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump, thank you for the review.
ENGCOM-3194 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@maheshWebkul721 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@mahesh-rajawat
Copy link
Member Author

#SQUASHTOBERFEST

@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@mahesh-rajawat mahesh-rajawat deleted the special-price-reviewed branch October 29, 2018 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants