Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Issue: Special price of 0.0000 is not shown on frontend, but is calculated in cart #18604

Merged
merged 4 commits into from
Oct 25, 2018
Merged

Fixed Issue: Special price of 0.0000 is not shown on frontend, but is calculated in cart #18604

merged 4 commits into from
Oct 25, 2018

Conversation

mahesh-rajawat
Copy link
Member

Fixed issue of product with a special price of 0.00, this is not shown on the frontend. Not in the product listings and also not on the product detail page.

Description (*)

Product Special Price is set to 0 then its not visible on product listing and Product View page, but when
we add product in cart, its price added to 0 in cart. In this pull request i have fixed this issue, now
Special price is displaying 0 as well.

Fixed Issues (if relevant)

  1. M2.2.6 : Special price of 0.0000 is not shown on frontend, but is calculated in cart #18268: Special price of 0.0000 is not shown on frontend, but is calculated in car

Manual testing scenarios (*)

  1. Created new product and set the special price 0 and saved it.
  2. Open product in category page special price is displaying 0 as normal.
  3. Open product in product view page special price is displaying 0.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 14, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rodrigowebjump rodrigowebjump self-requested a review October 15, 2018 11:12
@rodrigowebjump rodrigowebjump self-assigned this Oct 15, 2018
@rodrigowebjump
Copy link
Member

rodrigowebjump commented Oct 15, 2018 •
edited
Loading

Hi @maheshWebkul721

We are trying to have everything merged on 2.3 before merging it to 2.2 and others.
Thus, I would kindly ask you to change the branch to 2.3.
It's up to you to decide whether to create a new PR or edit this one.

I already reviewed your code and it is ok.

Also, do not forget to check the license/CLA.

@mahesh-rajawat
Copy link
Member Author

Ok @rodrigowebjump , I am going to create new pull request for 2.3-develop

mahesh-rajawat pushed a commit to mahesh-rajawat/magento2 that referenced this pull request Oct 15, 2018
reference pull request of magento#18604 for 2.3-develop
e30a12e
@testmagento2
Copy link

Hi
I found a temporary solution by create catalog price rule and it changed the price to 0

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Oct 16, 2018
@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump, thank you for the review.
ENGCOM-3195 has been created to process this Pull Request

@mahesh-rajawat
Copy link
Member Author

#SQUASHTOBERFEST

@sidolov
Copy link
Contributor

sidolov commented Oct 16, 2018

Hi @maheshWebkul721 , looks like commits in current PR were made with the different email than in your GitHub profile, please, add email from commits to your profile and sign the CLA.
Thank you!

@mahesh-rajawat
Copy link
Member Author

@sidolov , email added and signed CLA

@sidolov
Copy link
Contributor

sidolov commented Oct 23, 2018

Hi @maheshWebkul721 , few commits with different email still present in the PR, please, take a look
Thank you!

@sidolov sidolov mentioned this pull request Oct 25, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 899a8a3 into magento:2.2-develop Oct 25, 2018
magento-engcom-team pushed a commit that referenced this pull request Oct 25, 2018
ENGCOM-3195: Fixed Issue: Special price of 0.0000 is not shown on fro…
43c50c3 
…ntend, but is calculated in cart #18604
@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@gelanivishal gelanivishal mentioned this pull request Oct 25, 2018
Closed
4 tasks
@mahesh-rajawat mahesh-rajawat mentioned this pull request Oct 25, 2018
Merged
4 tasks
magento-engcom-team added a commit that referenced this pull request Oct 27, 2018
@magento-engcom-team
ENGCOM-3194: Reference pull request of #18604 for 2.3-develop #18631
af1faec 
 - Merge Pull Request #18631 from maheshWebkul721/magento2:special-price-reviewed
 - Merged commits:
   1. e30a12e
magento-engcom-team pushed a commit that referenced this pull request Oct 27, 2018
ENGCOM-3194: Reference pull request of #18604 for 2.3-develop #18631
110e7b6
magento-engcom-team pushed a commit that referenced this pull request Oct 27, 2018
🔃 [EngCom] Public Pull Requests - 2.3-develop
77af5d6 
Accepted Public Pull Requests:
 - #18795: [Forwardport] Fix customer unsubscribed issue (by @janakbhimani)
 - #18788: Remove useless semicolon statements (by @mage2pratik)
 - #18792: Remove unnecessary conditional statements (by @gy741)
 - #18782: [Forwardport] 15259 : Unable to disable without providing Industry value (by @mage2pratik)
 - #18771: Cover \Magento\CheckoutAgreements\Model\ResourceModel\Agreement\Grid\Collection class with Integration test (by @TomashKhamlai)
 - #18764: Replace intval() function by using direct type casting to (int) (by @gelanivishal)
 - #18751: Language cleanup on mass actions from the Customers grid (by @p-maguire)
 - #18756: Remove Duplicate field (by @gy741)
 - #18714: Fix for Issue #4468 "Unable to insert multiple catalog product list widgets (with pager) in CMS page" (by @vasilii-b)
 - #18730: Sections LESS mixins: fix the issue with missing rules and incorrect default variables (by @dmytro-ch)
 - #18689: ISSUE-5021 - fixed place order for custom shipping methods with under… (by @idziakjakub)
 - #18720: Prevent exception when option text converts to false (by @pmclain)
 - #18725: Fix Useless use of Cat (by @gy741)
 - #18412: Fixes #18357 - SQL error when table prefix used. (by @pocallaghan)
 - magento-engcom/import-export-improvements#120: MAGETWO-34709 Changing empty label value for first option on dropdown filters. (by @valentinboyanov)
 - #18704: Allow set billing information via API with existing address (by @pmclain)
 - #18095: #17744 Adding logic to get default billing address used on Cart and Checkout (by @LucasCalazans)
 - #18679: Set fallback values for email and _website columns to avoid 'undefined index' error in CustomerComposite.php (by @TomashKhamlai)
 - #18639: Fix SKU limit in import new products (by @ravi-chandra3197)
 - #18622: [BUGFIX] [issue-10205] Always set the entity_type_id for updating pro� (by @lewisvoncken)
 - #18611: Ensure integer values are not quoted as strings (by @udovicic)
 - #18631: Reference pull request of #18604 for 2.3-develop (by @maheshWebkul721)
 - #18388: Add class into image builder (by @VincentMarmiesse)
 - #18790: fixed Product Advanced Pricing design issue #18775 (by @ashutoshwebkul)
 - #18019: Adding trimming sku value function to sku backend model. (by @bartoszkubicki)


Fixed GitHub Issues:
 - #17954: Customer get unsubscribe to newsletter on password reset email request with Newsletter Need to Confirm Set to Yes on admin settings (reported by @matin73) has been fixed in #18795 by @janakbhimani in 2.3-develop branch
   Related commits:
     1. 6e9d5e5

 - #15259: Advanced Reporting > Unable to disable without providing Industry value (reported by @Detzler) has been fixed in #18782 by @mage2pratik in 2.3-develop branch
   Related commits:
     1. 6862c04

 - #18357: checkout_agreement_store doesn't exist (reported by @michelecanal) has been fixed in #18771 by @TomashKhamlai in 2.3-develop branch
   Related commits:
     1. 3cba00c
     2. 86e035f

 - #4468: Unable to insert multiple catalog product list widgets in CMS page (reported by @kandrejevs) has been fixed in #18714 by @vasilii-b in 2.3-develop branch
   Related commits:
     1. 0a25364

 - #18729: Bug in "_sections.less" mixins: missing rules and incorrect default variables (reported by @dmytro-ch) has been fixed in #18730 by @dmytro-ch in 2.3-develop branch
   Related commits:
     1. 19a2d2f
     2. 310afd8

 - #5021: "Please specify a shipping method" Exception (reported by @vphat28) has been fixed in #18689 by @idziakjakub in 2.3-develop branch
   Related commits:
     1. 9688034

 - #13083: OptionManagement.validateOption throws NoSuchEntityException for "0" option label (reported by @rzinnatullin) has been fixed in #18720 by @pmclain in 2.3-develop branch
   Related commits:
     1. ed6a2fb

 - #18357: checkout_agreement_store doesn't exist (reported by @michelecanal) has been fixed in #18412 by @pocallaghan in 2.3-develop branch
   Related commits:
     1. 2bee366

 - #17485: Adding billing information via mine API expects costumer id (reported by @wittyvishwas) has been fixed in #18704 by @pmclain in 2.3-develop branch
   Related commits:
     1. 7584f71

 - #17744: Virtual-only quotes use default shipping address for estimation instead of default billing address (reported by @navarr) has been fixed in #18095 by @LucasCalazans in 2.3-develop branch
   Related commits:
     1. a44eb5d
     2. 0890139
     3. 5372c7d
     4. b871ea9
     5. ec5d9b7
     6. a862620
     7. f3bad34

 - #17865: import new products via csv: products are created with empty value when strings are too long (reported by @LouNik1984) has been fixed in #18639 by @ravi-chandra3197 in 2.3-develop branch
   Related commits:
     1. 499cdd7
     2. a9bc411
     3. b65b49f
     4. 5790225

 - #10205: REST API /V1/products/attributes does not update all properties (reported by @sazzle2611) has been fixed in #18622 by @lewisvoncken in 2.3-develop branch
   Related commits:
     1. 42ecb9c

 - #18268: M2.2.6 : Special price of 0.0000 is not shown on frontend, but is calculated in cart (reported by @kanduvisla) has been fixed in #18631 by @maheshWebkul721 in 2.3-develop branch
   Related commits:
     1. e30a12e

 - #18775: Product Advanced Pricing design issue (reported by @saphaljha) has been fixed in #18790 by @ashutoshwebkul in 2.3-develop branch
   Related commits:
     1. 6bb8258

 - #12300: SKU values are not trimmed with the space. (reported by @ShaileshChauhan92) has been fixed in #18019 by @bartoszkubicki in 2.3-develop branch
   Related commits:
     1. 6c168dd

 - #16572: Trim whitespace on SKU when saving product (reported by @Zyles) has been fixed in #18019 by @bartoszkubicki in 2.3-develop branch
   Related commits:
     1. 6c168dd
gelanivishal pushed a commit to gelanivishal/magento2 that referenced this pull request Oct 27, 2018
@gelanivishal
reference pull request of magento#18604 for 2.3-develop
a6d27dd
@ghost ghost mentioned this pull request Apr 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigowebjump rodrigowebjump rodrigowebjump approved these changes

Assignees

@rodrigowebjump rodrigowebjump

Labels
Award: bug fix Component: Catalog Event: squashtoberfest Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.8
Development

Successfully merging this pull request may close these issues.
6 participants
@mahesh-rajawat @magento-cicd2 @magento-engcom-team @rodrigowebjump @testmagento2 @sidolov