icon text showing feature

[Karlasa]

added feature to show text when icon is set to false

Description (*)

Added feature to force set show text = true when icon is set to false. Currently when you want to remove icon you have to go and set each @_icon-font-text-hide = true manually
It would make more sense to have it always shown when icon not existing.

Fixed Issues (if relevant)

Manual testing scenarios (*)

add icon with @_icon-font-text-hide= false and also icon-content = false
text should be shown as icon is false

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @Karlasa. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[okorshenko]

Hi @Karlasa
Thank you for your contribution. Could you please look at the broken tests? looks like there is an issue with static files compilation.

[okorshenko]

hi @Karlasa
Thank you update! 👍

[magento-engcom-team]

Hi @okorshenko, thank you for the review.
ENGCOM-3229 has been created to process this Pull Request

[ghost]

Hi @Karlasa, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.