-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] icon text showing feature #21203
[Backport] icon text showing feature #21203
Conversation
added feature to show text when icon is set to false
fix typo
Hi @mage2pratik. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @VladimirZaets, thank you for the review. |
✔️ QA Passed |
Hi @mage2pratik, thank you for your contribution! |
Original Pull Request
#18706
added feature to show text when icon is set to false
Description (*)
Added feature to force set show text = true when icon is set to false. Currently when you want to remove icon you have to go and set each @_icon-font-text-hide = true manually
It would make more sense to have it always shown when icon not existing.
Fixed Issues (if relevant)
Manual testing scenarios (*)
add icon with @_icon-font-text-hide= false and also icon-content = false
text should be shown as icon is false
Contribution checklist (*)