-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes theme header logo and icon upload #18851
Fixes theme header logo and icon upload #18851
Conversation
Hi @wiardvanrij. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@magento-engcom-team give me 2.3-develop instance |
Hi @rogyar. Thank you for your request. I'm working on Magento 2.3-develop instance for you |
Hi @rogyar, here is your Magento instance. |
@magento-engcom-team give me test instance |
Hi @rogyar. Thank you for your request. I'm working on Magento instance for you |
Hi @rogyar, here is your new Magento instance. |
@wiardvanrij thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
Anyone knows why travis did not run properly? |
The issue with Travis will be fixed soon |
Hi @wiardvanrij. Thank you for your contribution. |
Hello, I am facing the same problem, I cannot upload logo/favicon image. I am using Magento 2.3.0 and php 7.2.8. Anyone with a fix? |
I have the same problem with a fresh install of 2.3 trying to change the Transactional Email Logo. I click Upload to upload the logo image, choose the image and I get a running circle for a second and nothing is ever added. No logo image is displayed in the backend at all and the image in the email is still the default Magento logo. I can confirm that changing the core design_config_form.xml (not recommended) @valikvali does work. |
Description (*)
With the change of "fileuploader" to "imageuploader" the correct formElement was not updated to match the new "imageuploader".
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)