Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference PL of #18928 for 2.3-develop #18930

Closed

Conversation

mahesh-rajawat
Copy link
Member

Reference #18928
Fixed Issue of Place an order as an guest, the displayed customer name in the admin order management is "Guest". If the guest has created an account after placing the order, it is a link that points to the customer's account management. Invoice and shipping are also affected.

Description (*)

If Order is placed by Guest user in admin Order view, Invoice view, Shipment view, displaying Customer
name as "Guest", issue was in the quote management, its only set email for the customer, Now i have it
in this pull request.

Fixed Issues (if relevant)

  1. Customer name in adminhtml's order management is "Guest" #18616: Customer name in adminhtml's order management is "Guest"

Manual testing scenarios (*)

  1. ...
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur
Copy link
Contributor

@slavvka PR against 2.3-develop should be processed first according to current process I believe.

@slavvka
Copy link
Member

slavvka commented Oct 31, 2018

@orlangur I would say PR to 2.3 should be merged before PR to 2.2. But that doesn't mean that PR to 2.2 cannot be completed and than changes are moved to 2.3

@mahesh-rajawat mahesh-rajawat requested review from orlangur and rogyar and removed request for rogyar November 15, 2018 18:36
@mahesh-rajawat
Copy link
Member Author

@slavvka , whats the status for this PR?

@slavvka
Copy link
Member

slavvka commented Nov 15, 2018

Hey @maheshWebkul721 I asked you in your PR to 2.2 to cover your change with the automated test.

@slavvka
Copy link
Member

slavvka commented Nov 15, 2018

@maheshWebkul721 But since this PR will be processed firstly, my ask relates to it as well.

@slavvka
Copy link
Member

slavvka commented Nov 16, 2018

@maheshWebkul721 I am closing this PR since we have another PR #19191 which has better fix and it is covered with automated tests. Thank you for your collaboration!

@slavvka slavvka closed this Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants