Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customer related values are NULL for guests converted to customers after checkout. #19166 #19191

Merged
merged 8 commits into from
Feb 18, 2019

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Nov 13, 2018

Description (*)

Customer name and all customer related values should not be NULL

Fixed Issues (if relevant)

  1. Customer related values are NULL for guests converted to customers after checkout. #19166:Customer related values are NULL for guests converted to customers after checkout.

Manual testing scenarios (*)

  1. Allow customers to create account after checkout
  2. Create few orders as guest customers and create an account after checkout process
  3. Create a module with a plugin aroundSave for SalesOrder class
  4. In aroundSave method, try to fetch customer name from order object
public function aroundSave(
        OrderResource $subject,
        \Closure $proceed,
        SalesOrder $order
    ) {
        [...]
        if ($order->getCustomerId()) {
            $customerName = $order->getCustomerName(); // returns Customer Name
        [...]
        }
    }

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Nov 13, 2018
@Nazar65
Copy link
Member Author

Nazar65 commented Nov 14, 2018

@orlangur I'm have made changes.

@slavvka
Copy link
Member

slavvka commented Nov 15, 2018

This PR is a duplicate of #18930

@Nazar65
Copy link
Member Author

Nazar65 commented Nov 16, 2018

@slavvka But i'm have a better solution, and i'm already cover all changes with the integration tests.

@Nazar65
Copy link
Member Author

Nazar65 commented Nov 30, 2018

Hi @orlangur any updates ?

@orlangur orlangur self-assigned this Dec 1, 2018
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nazar65 didn't plan to process this one, but anyway... Looks good to me!

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-3477 has been created to process this Pull Request

@okorshenko okorshenko removed this from the Release: 2.3.1 milestone Jan 28, 2019
@ghost
Copy link

ghost commented Feb 18, 2019

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants