Fix issue 19052- Position order showing before the text box

[speedy008]

Description (*)

You will find the position order showing before the text box as well when we can find the same value in textbox as well.

Fixed Issues (if relevant)

1. Position order showing before the text box #19052: Position order showing before the text box

Manual testing scenarios (*)

1. Catalog > Category > Choose any category > Go to Product in category tab > Assign products.
2. Product position order before textbox.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @speedy008. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[VladimirZaets]

Hi @speedy008. Thanks for collaboration. I am not sure that removing code is a valid fix for this issue. I see that here we have a checking getEditOnly(). Maybe the reason of this problem that the value returned from getEditOnly is wrong?

Also, it's abstract renderer class and I am not sure that fix should be in this place. This class is using in a lot of places, but problem we have only on the Assign products grid

[speedy008]

Hi @VladimirZaets
Thanks for your genuine response.
I will update code with proper solution and update it as early as possible.

[magento-cicd2]

All committers have signed the CLA.

[speedy008]

Hi @VladimirZaets Could you please check what cause failed travis?

Thanks,

[sidolov]

Hi @speedy008 , looks like you made some commits with email different than in your GitHub profile, please, add email from commits to your profile!
Thank you!

[sidolov]

Hi @VladimirZaets Could you please check what cause failed travis?

Thanks,

Travis failure caused by changes provided in the PR.
Failed unit test: Magento\Backend\Test\Unit\Block\Widget\Grid\Column\Renderer\AbstractRendererTest::testRender

[speedy008]

Hi @VladimirZaets
I have updated code.

[magento-engcom-team]

Hi @VladimirZaets, thank you for the review.
ENGCOM-3766 has been created to process this Pull Request

[ghost]

Hi @speedy008, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[magento-engcom-team]

Hi @speedy008. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.