Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Fix issue 19052- Position order showing before the text box #20094

Conversation

davidverholen
Copy link
Member

Original Pull Request

#19056

Description (*)

You will find the position order showing before the text box as well when we can find the same value in textbox as well.

Fixed Issues (if relevant)

  1. Position order showing before the text box #19052: Position order showing before the text box

Manual testing scenarios (*)

  1. Catalog > Category > Choose any category > Go to Product in category tab > Assign products.
  2. Product position order before textbox.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@davidverholen davidverholen force-pushed the 2.3-develop-PR-port-19056 branch from 6c54044 to 53943f8 Compare January 6, 2019 17:00
@magento-engcom-team
Copy link
Contributor

Hi @davidverholen. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Member

@rodrigowebjump rodrigowebjump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @davidverholen Thanks for your contribution

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump, thank you for the review.
ENGCOM-3798 has been created to process this Pull Request

@ghost
Copy link

ghost commented Jan 23, 2019

Hi @davidverholen, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @davidverholen. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants