Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for making subcategories appear in breadcrumbs (Backport) #19760

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Conversation

Yamaha32088
Copy link
Contributor

@Yamaha32088 Yamaha32088 commented Dec 14, 2018

Description (*)

The typo will break sub categories from appearing in the breadcrumbs

Fixed Issues (if relevant)

  1. Problems with breadcrumbs #7967: Problems with breadcrumbs

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Backport for: #19781

The typo will break sub categories from appearing in the breadcrumbs
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Dec 14, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @Yamaha32088. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar
Copy link
Contributor

rogyar commented Dec 14, 2018

Hi @Yamaha32088. Thank you for your contribution. According to the contributor guide (https://devdocs.magento.com/guides/v2.2/contributor-guide/contributing.html#rules) we cannot accept a change into 2.2-develop branch before the change is merged into 2.3-develop branch. Please, consider creating the same fix for 2.3-develop and rename the current pull request as backport. Thank you.

@orlangur orlangur self-assigned this Dec 14, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Dec 14, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-3697 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@Yamaha32088 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@Yamaha32088 Yamaha32088 changed the title Fix for making subcategories appear in breadcrumbs Fix for making subcategories appear in breadcrumbs (Backport) Dec 14, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3697 has been created to process this Pull Request

@okorshenko okorshenko removed this from the Release: 2.2.8 milestone Jan 28, 2019
@magento-engcom-team magento-engcom-team merged commit bf7ee62 into magento:2.2-develop Feb 8, 2019
@ghost
Copy link

ghost commented Feb 8, 2019

Hi @Yamaha32088, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@liquidia
Copy link

this still not fixed in 2.3.3 ?

@anil90
Copy link

anil90 commented Feb 17, 2020

i am also facing this issue with 2.3.2
Anyone here who can confirm if its resolved?

@nicholasscottfish
Copy link

nicholasscottfish commented Dec 10, 2021

Any update on this issue? Still experiencing the missing breadcrumbs on 2.4.3-p1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants