-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for making subcategories appear in breadcrumbs #19781
Fix for making subcategories appear in breadcrumbs #19781
Conversation
Hi @Yamaha32088. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @Yamaha32088 , thanks for the contribution! Can you please update the https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Catalog/Test/Unit/ViewModel/Product/BreadcrumbsTest.php |
@sivaschenko done. Thanks for catching that |
Hi @orlangur, thank you for the review. |
Hi @Yamaha32088 we cannot reproduce the issue on 2.3-develop. We used the following manual testing scenario:
Actual Result: Breadcrumbs contain categories Are there any details that we missed while verification of the issue? |
Hello @sivaschenko that appears to be the correct steps. Did you make sure that it wasn't using the fallback option of the "HTTP Referrer"? I found the bug on a site that was migrated from Magento 1.x to 2.x, although I don't suspect that would cause any differences on how products are linked to categories. I just know that it is definitely a typo and there were no sub-categories appearing for me until I fixed it. |
Hi @Yamaha32088, thank you for your contribution! |
Hi @Yamaha32088. Thank you for your contribution. |
Description (*)
The typo will break sub categories from appearing in the breadcrumbs
Fixed Issues (if relevant)
Contribution checklist (*)