Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for making subcategories appear in breadcrumbs #19781

Merged
merged 3 commits into from
Jan 14, 2019
Merged

Fix for making subcategories appear in breadcrumbs #19781

merged 3 commits into from
Jan 14, 2019

Conversation

Yamaha32088
Copy link
Contributor

Description (*)

The typo will break sub categories from appearing in the breadcrumbs

Fixed Issues (if relevant)

  1. Problems with breadcrumbs #7967: Problems with breadcrumbs

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @Yamaha32088. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sivaschenko
Copy link
Member

@Yamaha32088
Copy link
Contributor Author

@sivaschenko done. Thanks for catching that

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-3698 has been created to process this Pull Request

@sivaschenko
Copy link
Member

Hi @Yamaha32088 we cannot reproduce the issue on 2.3-develop. We used the following manual testing scenario:

  • Create nesting category: Default Category->A1->A2->A3->A4->A5
  • Create product and assign to category A5.
  • Go to product detail page

Actual Result: Breadcrumbs contain categories

Are there any details that we missed while verification of the issue?

@Yamaha32088
Copy link
Contributor Author

Hello @sivaschenko that appears to be the correct steps. Did you make sure that it wasn't using the fallback option of the "HTTP Referrer"? I found the bug on a site that was migrated from Magento 1.x to 2.x, although I don't suspect that would cause any differences on how products are linked to categories. I just know that it is definitely a typo and there were no sub-categories appearing for me until I fixed it.

@magento-engcom-team magento-engcom-team merged commit 1ffeda8 into magento:2.3-develop Jan 14, 2019
@ghost
Copy link

ghost commented Jan 14, 2019

Hi @Yamaha32088, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @Yamaha32088. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants