Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in breadcrumbs component on product page #21012

Closed

Conversation

ilnytskyi
Copy link
Contributor

Description (*)

Breadcrumbs on product page do not build well since parametr given into uiComponent has typo

Fixed Issues (if relevant)

  1. Not all Breadcrumbs are present on the product page if URL includes categories  #21011 Not all Breadcrumbs are present on the product page if URL includes categories

Manual testing scenarios (*)

  1. Open product page using direct link including category path
  2. See category tree in breadcrumbs

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @ilnytskyi. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Contributor

@swnsma swnsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ilnytskyi,
Thank you for your contribution!

Could you please check failed unit-tests:
\Magento\Catalog\Test\Unit\ViewModel\Product\BreadcrumbsTest::productJsonEncodeDataProvider

@swnsma
Copy link
Contributor

swnsma commented Feb 24, 2019

Hi @ilnytskyi,
I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@swnsma swnsma closed this Feb 24, 2019
@ghost
Copy link

ghost commented Feb 24, 2019

Hi @ilnytskyi, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@swnsma
Copy link
Contributor

swnsma commented Feb 24, 2019

#19781

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants