Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Product image failure when importing through CSV #20098 #20127

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Product image failure when importing through CSV #20098 #20127

merged 1 commit into from
Jan 16, 2019

Conversation

irajneeshgupta
Copy link
Member

@irajneeshgupta irajneeshgupta commented Jan 8, 2019 •
edited
Loading

Description (*)

Remote image file import by csv , it was failed because $filePath variable was overridden incorrectly in Uploader.php public function move($fileName, $renameFileOff = false).
Updated $filePath to $relativePath in case of remote URL image.

Fixed Issues (if relevant)

  1. Product image failure when importing through CSV #20098: Issue Product image failure when importing through CSV Product image failure when importing through CSV #20098

Manual testing scenarios (*)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @irajneeshgupta. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

nuzil
nuzil requested changes Jan 8, 2019
View reviewed changes
app/code/Magento/CatalogImportExport/Model/Import/Uploader.php Outdated
@@ -180,9 +180,9 @@ public function move($fileName, $renameFileOff = false)
}

$fileName = preg_replace('/[^a-z0-9\._-]+/i', '', $fileName);
$filePath = $this->_directory->getRelativePath($filePath . $fileName);
$tempPath = $this->_directory->getRelativePath($filePath . $fileName);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please use kind of "$relativePath" variable name? Its more clear then what is it doing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nuzil
Yes sure

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nuzil
I have updated it in latest commit.
Thanks.

@nuzil nuzil self-assigned this Jan 8, 2019
@irajneeshgupta irajneeshgupta requested a review from nuzil January 8, 2019 17:57
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 8, 2019
@magento-engcom-team
Copy link
Contributor

Hi @nuzil, thank you for the review.
ENGCOM-3809 has been created to process this Pull Request

@irajneeshgupta irajneeshgupta mentioned this pull request Jan 11, 2019
Closed
4 tasks
@magento-engcom-team magento-engcom-team mentioned this pull request Jan 16, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 7f4dffd into magento:2.3-develop Jan 16, 2019
@ghost
Copy link

ghost commented Jan 16, 2019

Hi @irajneeshgupta, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jan 16, 2019
@sivaschenko
ENGCOM-3809: Product image failure when importing through CSV #20098 #…
46340c4 
…20127
@magento-engcom-team
Copy link
Contributor

Hi @irajneeshgupta. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@irajneeshgupta irajneeshgupta mentioned this pull request Jan 16, 2019
Merged
4 tasks
@milindsingh milindsingh mentioned this pull request Jan 16, 2019
Closed
@ghost ghost mentioned this pull request Mar 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuzil nuzil nuzil approved these changes

@AlexMaxHorkun AlexMaxHorkun Awaiting requested review from AlexMaxHorkun

Assignees

@nuzil nuzil

Labels
Award: bug fix Community Insider: Cedcommerce community-insider-contribution Component: CatalogImportExport Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@irajneeshgupta @magento-engcom-team @nuzil