Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import external Images fix for products #20226

Closed
wants to merge 1 commit into from

Conversation

mik1781p
Copy link

@mik1781p mik1781p commented Jan 11, 2019

Description (*)

During the import of products which images come from an external source, like s3, the import will fail due to double assignment on file path variable.
Issue replicated in: 2.3 - 2.2.7

Manual testing scenarios (*)

  1. Create a CSV for product input that tries to import files from S3 or any other media storage/website/external source
    2.Try to import the csv with the magento standard tools
  2. An error will appear due to the inhability to import the file (Actually the file will be downloaded, but will be impossible to move it from tmp dir to the catalog/product media dir)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team give me test instance
@magento-engcom-team give me 2.3-develop instance

… assignment would generate a false path which leads to possible import errors.
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jan 11, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @mik1781p. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 11, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3836 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@mik1781p thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@irajneeshgupta
Copy link
Member

irajneeshgupta commented Jan 11, 2019

This is a dublicate PR reference. #20127

@ghost
Copy link

ghost commented Jan 11, 2019

Hi @mik1781p, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants