Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue fixed #20163 On iPhone5 device newsletter subscription input bo… #20165

Merged
merged 3 commits into from
Feb 14, 2019
Merged

issue fixed #20163 On iPhone5 device newsletter subscription input bo… #20165

merged 3 commits into from
Feb 14, 2019

Conversation

cedarvinda
Copy link
Member

…x not contain complete text (placeholder)

issue fixed #20163 On iPhone5 device newsletter subscription input box not contain complete text (placeholder)

Description (*)

On iPhone device newsletter subscription input box not contain complete text (placeholder)

Manual testing scenarios (*)

1.Go to iphone5 device and check newsletter subscription block above footer

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…x not contain complete text (placeholder)

issue fixed #20163 On iPhone5 device newsletter subscription input box not contain complete text (placeholder)
@magento-engcom-team
Copy link
Contributor

Hi @cedarvinda. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sivaschenko
Copy link
Member

Hi @cedarvinda , thanks for your contribution! The PR specifies the custom font-size for mobile, can you please ensure the default font size is still used on desktop.

@cedarvinda
Copy link
Member Author

@sivaschenko Thankyou for review... I will update the font-size in media query.

…wsletter subscription input box not contain complete text

_module.less file updated for issue fixed #20163 On iPhone5 device newsletter subscription input box not contain complete text
@cedarvinda
Copy link
Member Author

@sivaschenko Now updated _module.less using media query.

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3992 has been created to process this Pull Request

@okorshenko okorshenko removed this from the Release: 2.3.1 milestone Jan 28, 2019
@ghost
Copy link

ghost commented Feb 14, 2019

Hi @cedarvinda, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment