Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK#iPhone5-device-newsletter-subscription #20167

Closed
wants to merge 2 commits into from
Closed

TASK#iPhone5-device-newsletter-subscription #20167

wants to merge 2 commits into from

Conversation

dipti2jcommerce
Copy link

On iPhone5 device newsletter subscription input box not contain complete text (placeholder)

Description (*)

changes is done for newsletter input text block in iphone5 device

Fixed Issues (if relevant)

On iPhone5 device newsletter subscription input box not contain complete text (placeholder) #20163

Manual testing scenarios (*)

2019-01-10_16-19_about us

Contribution checklist (*)

@magento-engcom-team
Copy link
Contributor

Hi @dipti2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sivaschenko sivaschenko self-assigned this Jan 10, 2019
@magento-cicd2
Copy link
Contributor

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ sivaschenko
❌ dipti2jcommerce

@sivaschenko
Copy link
Member

sivaschenko commented Jan 10, 2019 •
edited
Loading

Hi @dipti2jcommerce , thanks for the contribution, we'll be able to process the pull request once you sign the CLA

@sivaschenko
Copy link
Member

@dipti2jcommerce please take a look at #20165 fixing the same issue. That fix looks more appropriate to me as the correct media query is updated. Lets close this pull request and collaborate to process the earlier one.

@ghost
Copy link

ghost commented Jan 10, 2019

Hi @dipti2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

dipti2jcommerce pushed a commit to dipti2jcommerce/magento2 that referenced this pull request Jan 17, 2019
iPhone5-device-newsletter-subscription-magento#20167
c874bf5
magento-engcom-team added a commit that referenced this pull request Feb 19, 2019
@magento-engcom-team
ENGCOM-4303: iPhone5-device-newsletter-subscription-#20167 #20370
a65ce6e 
 - Merge Pull Request #20370 from dipti2jcommerce/magento2:iPhone5-device-newsletter-subscription-#20167
 - Merged commits:
   1. c874bf5
   2. 9f1a322
magento-engcom-team pushed a commit that referenced this pull request Feb 19, 2019
@sidolov
ENGCOM-4303: iPhone5-device-newsletter-subscription-#20167 #20370
e3e888d
magento-engcom-team added a commit that referenced this pull request Feb 19, 2019
@magento-engcom-team
🔃 [EngCom] Public Pull Requests - 2.2-develop
88ad7a6 
Accepted Public Pull Requests:
 - #21320: [Backport][Ui] Fixing the changing state of dropdown's icon (by @eduard13)
 - #21229: [Backport] Fixed product advanced pricing design issue (by @mage2pratik)
 - #21173: [Backport] fixes-customer-information-wishlist-configurable-product-alignment-2.2 (by @amol2jcommerce)
 - #20370: iPhone5-device-newsletter-subscription-#20167 (by @dipti2jcommerce)


Fixed GitHub Issues:
 - #21196: [UI] The dropdown state doesn't change if the dropdown is expanded or not (reported by @eduard13) has been fixed in #21320 by @eduard13 in 2.2-develop branch
   Related commits:
     1. 1e4055d

 - #18775: Product Advanced Pricing design issue (reported by @saphaljha) has been fixed in #21229 by @mage2pratik in 2.2-develop branch
   Related commits:
     1. 079d5d5

 - #20760: Admin Customer configuraion in whishlist associated product for configurable product misalign (reported by @nainesh2jcommerce) has been fixed in #21173 by @amol2jcommerce in 2.2-develop branch
   Related commits:
     1. e9102ec
     2. 17d416a
     3. 5d42fa8

 - #20163: On iPhone5 device newsletter subscription input box not contain complete text (placeholder)  (reported by @dipti2jcommerce) has been fixed in #20370 by @dipti2jcommerce in 2.2-develop branch
   Related commits:
     1. c874bf5
     2. 9f1a322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sivaschenko sivaschenko

Labels
Area: Design/Frontend duplicate Release Line: 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dipti2jcommerce @magento-engcom-team @magento-cicd2 @sivaschenko