Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #20187 Downloadble Price duplicate issue #20239

Merged
merged 1 commit into from
Mar 8, 2019
Merged

Fixed issue #20187 Downloadble Price duplicate issue #20239

merged 1 commit into from
Mar 8, 2019

Conversation

GovindaSharma
Copy link
Contributor

Fixed issue #20187 Downloadble Price duplicate issue

Description (*)

Fixed issue #20187 Downloadble Price duplicate issue

Fixed Issues (if relevant)

  1. Downloadable product view layout #20187: Issue title

Manual testing scenarios (*)

1.Install one downloadable product and one simple product
2.in frontend open both products in different browser tabs to compare the layout
3.Price is getting duplicated

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Resolved Duplicate Price issue in frontend
@magento-engcom-team
Copy link
Contributor

Hi @GovindaSharma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@GovindaSharma
Copy link
Contributor Author

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @GovindaSharma. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@sivaschenko sivaschenko self-assigned this Feb 3, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-4399 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@nmalevanec nmalevanec self-assigned this Mar 5, 2019
@magento-engcom-team magento-engcom-team merged commit e6f6422 into magento:2.3-develop Mar 8, 2019
@ghost
Copy link

ghost commented Mar 8, 2019

Hi @GovindaSharma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants