downloadable product view layout fix (issue #20187)

[melaxon]

Downloadable product view layout fix (issue #20187)

Description (*)

1. This fixes only catalog product view layout of of downloadables.
   The layout now is similar to simple or other types
2. Now the links are shown on frontend only if they sell separately or have samples. (Previously meaningless names of links also appeared)
3. Duplicate links title "Links" was removed as well.
   The layout on wishlist and maybe somewhere else still pending

Fixed Issues (if relevant)

ISSUE 20187

1. Downloadable product view layout #20187: Issue title: Downloadable product view layout
2. ...

Manual testing scenarios (*)

1. Install Magento 2.3.0
   2 Setup one downloadable product and one simple product, both with custom options
2. in frontend open both products in different browser tabs to compare the layout

Contribution checklist (*)

• [x ] Pull request has a meaningful description of its purpose
• [x ] All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @melaxon. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[milindsingh]

Aready created #20239

[melaxon]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @melaxon. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @melaxon, here is your new Magento instance.
Admin access: https://pr-20254.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[melaxon]

Screenshots from Vanila test:

1. Simple product to compare with
2. Downloadable product
3. Downloadable with links purchased separately
   
   
   

[sidolov]

Hi @melaxon unfortunately, we can't accept pull requests with zero changeset. Please, update your pull request and reopen it if you wish to continue.

[ghost]

Hi @melaxon, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.