Fixed #20282 Module Catalog Url Rewrite: Permanent Redirect for old URL is missed when product was imported

[verma-ankur]

Fixed ##20282 Module Catalog Url Rewrite: Permanent Redirect for old URL is missed when product was imported

You have to add one more column in you csv file named 'save_rewrites_history' set it to 1 or 0 based on your requirement. Set it to 1 if you want permanent redirect for old URL of your product.

Preconditions (*)

Magento 2.2.7

Steps to reproduce (*)

Export some visible product via System-> Data Transfer-> Export.
Change 'url-key' for this product in CSV file.
Import this product via System-> Data Transfer-> Import.

Expected result (*)

When you try to open the changed product by the old URL key you are redirected to the new URL.

Actual result (*)

When you try to open the changed product by the old URL key you receive 404-page.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @ankur-cedcoss. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[aleron75]

Hello,
I may be wrong but, as pointed here, this doesn't seem to be an issue.

Choosing whether to generate a redirect is optional in the Admin Panel, forcing it in import would not be consistent.

Let me know.

[verma-ankur]

@aleron75

The reference you provided is to handle every product URL rewrite manually.
And the solution I provided is to handle the URL rewrite automatically.

And my solution is not forcing to generate the URL rewrite.
It is still optional. If you want to generate the URL write for old URL then you have to pass this information in your import csv file.
For it you have to increase a column in your csv file named 'save_rewrites_history'. and you can pass value 1 or 0 for this column.
If you want to generate the rewrite set the 'save_rewrites_history' field value to 1.
other wise either set 0 or do not provide a value at all.

[aleron75]

Hello @ankur-cedcoss, thanks for the clarification.

[magento-engcom-team]

Hi @aleron75, thank you for the review.
ENGCOM-3925 has been created to process this Pull Request

[magento-engcom-team]

@ankur-cedcoss thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[ghost]

Hi @ankur-cedcoss, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[magento-engcom-team]

Hi @ankur-cedcoss. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

[magento-engcom-team]

Hi @ankur-cedcoss. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

[stijnkuppens]

There is still a bug in scenario. In file:
vendor/magento/module-catalog-url-rewrite/Observer/AfterImportDataObserver.php:currentUrlRewritesRegenerate()
around line 487

$urlRewrites = $url + $urlRewrites;

has to be:

$urlRewrites = array_merge($url,$urlRewrites);

Otherwise the new created url rewrites will not be saved.
The '+' will preserve the array keys without doing overrides. In this case we don't have specific array keys, thus the new rewrites are ignored and not added in the resulting array.