12386: Order Status resets to default Status after Partial Refund.

[nmalevanec]

Original Pull Request

https://github.com/magento-engcom/magento2ce/pull/1056

Description

Now order keeps previous status after partial refund, in case it's state has not been changed.

Fixed Issues (if relevant)

1. Order Status resets to default Status after Partial Refund #12386: Order Status resets to default Status after Partial Refund

Manual testing scenarios

1. Create new Order Status: "Picking"
2. Assign new State to Processing: "processing[Picking]", Do not check "Use Order Status As Default".
3. Create simple product.
4. Create order and Invoice with created product (qty = 2).
5. Update order status from Processing to Picking.
6. Refund part of order whilst in Picking Status(create Credit Memo with qty = 1).
7. Observe order status remains "Picking".
8. Refund remaining order items.
9. Observe order status changes to "Closed".
10. Repeat steps 4 and 5.
11. Make API rest call POST /V1/order/{your_order_Id}/refund with body ex:

{
  "items": [
    {
      "order_item_id": {your_order_item_id},
      "qty": 1
    }
  ]
}

12. Check order status in admin, it should remains "Picking".
13. Repeat API call.
14. Check order status become "Closed".

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @nmalevanec. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[orlangur]

@nmalevanec pretty cool pull request, dunno why it was abandoned 👍

[VasylShvorak]

✔️ QA passed

[m2-assistant]

Hi @nmalevanec, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.