-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes incorrect where condition when deleting swatch option, it delet… #20421
Fixes incorrect where condition when deleting swatch option, it delet… #20421
Conversation
…ed all options instead of a specific one.
Hi @hostep. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@magento-engcom-team give me 2.3-develop instance |
Hi @rogyar. Thank you for your request. I'm working on Magento 2.3-develop instance for you |
Hi @rogyar, here is your Magento instance. |
Hi @hostep, thank you for your contribution! |
Hi @hostep. Thank you for your contribution. |
1 similar comment
Hi @hostep. Thank you for your contribution. |
…ed all options instead of a specific one.
Description (*)
This fixes an incorrect where condition in the SQL query which should delete a specific swatch option.
It changes the SQL query from (which deletes all options):
to (9 is an example here):
Fixed Issues (if relevant)
Manual testing scenarios (*)
See description in #20396
You don't need products, just create 2 swatch attributes, and change one of them to dropdown to reproduce the problem.
Contribution checklist (*)