Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes incorrect where condition when deleting swatch option, it delet… #20421

Merged
merged 2 commits into from
Jan 29, 2019

Conversation

hostep
Copy link
Contributor

@hostep hostep commented Jan 19, 2019

…ed all options instead of a specific one.

Description (*)

This fixes an incorrect where condition in the SQL query which should delete a specific swatch option.
It changes the SQL query from (which deletes all options):

DELETE FROM `eav_attribute_option_swatch` WHERE (option_id)

to (9 is an example here):

DELETE FROM `eav_attribute_option_swatch` WHERE (option_id = 9)

Fixed Issues (if relevant)

  1. Changing attribute from swatch to dropdown deletes swatch options for all attributes #20396: Changing attribute from swatch to dropdown deletes swatch options for all attributes

Manual testing scenarios (*)

See description in #20396
You don't need products, just create 2 swatch attributes, and change one of them to dropdown to reproduce the problem.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @hostep. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar
Copy link
Contributor

rogyar commented Jan 20, 2019

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your Magento instance.
Admin access: https://i-20421-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@okorshenko okorshenko removed this from the Release: 2.3.1 milestone Jan 28, 2019
@magento-engcom-team magento-engcom-team merged commit 6829ce8 into magento:2.3-develop Jan 29, 2019
@ghost
Copy link

ghost commented Jan 29, 2019

Hi @hostep, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @hostep. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

1 similar comment
@magento-engcom-team
Copy link
Contributor

Hi @hostep. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants