Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fixes incorrect where condition when deleting swatch option, it delet… #20745

Conversation

amol2jcommerce
Copy link
Contributor

Original Pull Request

#20421
…ed all options instead of a specific one.

Description (*)

This fixes an incorrect where condition in the SQL query which should delete a specific swatch option.
It changes the SQL query from (which deletes all options):

DELETE FROM `eav_attribute_option_swatch` WHERE (option_id)

to (9 is an example here):

DELETE FROM `eav_attribute_option_swatch` WHERE (option_id = 9)

Fixed Issues (if relevant)

  1. Changing attribute from swatch to dropdown deletes swatch options for all attributes #20396: Changing attribute from swatch to dropdown deletes swatch options for all attributes

Manual testing scenarios (*)

See description in #20396
You don't need products, just create 2 swatch attributes, and change one of them to dropdown to reproduce the problem.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@amol2jcommerce
Copy link
Contributor Author

@magento-engcom-team please review.

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4120 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 8, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Feb 8, 2019
@sidolov sidolov added this to the Release: 2.2.9 milestone Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants