Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view-order-price-subtotal-alignment-not-proper-mobile #20466

Conversation

priti2jcommerce
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. Order item details label not aligned in mobile view  #20299: Order item details label not aligned in mobile view
  2. ...

Manual testing scenarios (*)

  1. Open frontend and login as customer
  2. Go to my account section
  3. Click on My order link and open detail any order in mobile
  4. You will issue as shown in screenshot

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @priti2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sdzhepa
Copy link
Contributor

sdzhepa commented Jan 30, 2019

Hello @priti2jcommerce

As we can see initial issue #20299 has been fixed and closed
Delivered in the scope of PR #20301 by @cedarvinda in 2.3-develop branch
Please see more details about commits in this comment #20299 (comment)

Could you confirm this PR can be closed?

Thank you for contribution and collaboration!

@sivaschenko
Copy link
Member

@sdzhepa I see that PR #20301 fixes this issue only for luma theme. @priti2jcommerce can you please update your branch (to fetch changes introduced by merged PR) and provide the fix only for the blank theme in this PR.

@priti2jcommerce
Copy link
Contributor Author

Hi @sdzhepa and @sivaschenko ,

thanks for the update, I will make the changes

@priti2jcommerce
Copy link
Contributor Author

Hi @sdzhepa and @sidolov ,

I update branch now and provide the fix only for the blank theme in this PR.

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-4069 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 14, 2019

Hi @priti2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants