Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] view-order-price-subtotal-alignment-not-proper-mobile #21243

Conversation

amol2jcommerce
Copy link
Contributor

Original Pull Request

#20466

Description (*)

Fixed Issues (if relevant)

  1. Order item details label not aligned in mobile view  #20299: Order item details label not aligned in mobile view
  2. ...

Manual testing scenarios (*)

  1. Open frontend and login as customer
  2. Go to my account section
  3. Click on My order link and open detail any order in mobile
  4. You will issue as shown in screenshot

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4283 has been created to process this Pull Request

@sdzhepa
Copy link
Contributor

sdzhepa commented Feb 15, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, here is your new Magento instance.
Admin access: https://pr-21243.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@sdzhepa
Copy link
Contributor

sdzhepa commented Feb 15, 2019

Hello @amol2jcommerce

Thank you for contribution and collaboration!

During testing, I found the issue was not fixed.
Could you please take a look and fix?

  1. Tested in Google Chrome.
    Actual result on the branch with PR:
    pr21243_gh

  2. Tested on physical iPhone5
    Actual result on the branch with PR:
    pr21243

@amol2jcommerce
Copy link
Contributor Author

Hi @sdzhepa branch updated. please review.

@sdzhepa
Copy link
Contributor

sdzhepa commented Feb 19, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, here is your new Magento instance.
Admin access: https://pr-21243.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@ghost
Copy link

ghost commented Feb 20, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants