Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tooltip-dropdown-pointer :: Tooltip dropdown pointer not proper on ta… #20488

Conversation

ranee2jcommerce
Copy link
Contributor

…blet

Description (*)

Fixed Issues (if relevant)

  1. On checkout page tooltip dropdown pointer not proper on tablet #20487: On checkout page tooltip dropdown pointer not proper on tablet
  2. ...

Manual testing scenarios (*)

  1. Add product to cart
  2. On checkout page click on "question mark" icon besides Email Address field
  3. Tooltip dropdown opens, pointer not points to icon

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @ranee2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar
Copy link
Contributor

rogyar commented Jan 23, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-20488.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@rogyar rogyar self-assigned this Jan 23, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 23, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-3938 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 1, 2019

Hi @ranee2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team merged commit 3b63526 into magento:2.3-develop Feb 1, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants