Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fixed-checkout-tooltip-dropdown #20490

Conversation

amol2jcommerce
Copy link
Contributor

@amol2jcommerce amol2jcommerce commented Jan 23, 2019

Description (*)

Original PR: #20488

Fixed Issues (if relevant)

  1. tooltip-dropdown-pointer :: Tooltip dropdown pointer not proper on ta… #20488: On checkout page tooltip dropdown
  2. Magento 2.2.x

Manual testing scenarios (*)

  1. Add product to cart
  2. On checkout page click on "question mark" icon besides Email Address field
  3. Tooltip dropdown opens, pointer not points to icon

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar rogyar changed the title Fixed-checkout-tooltip-dropdown [Backport] Fixed-checkout-tooltip-dropdown Jan 23, 2019
@amol2jcommerce
Copy link
Contributor Author

Hi @rogyar ,

Our pull request for 2.2-develop branch same changes are present in the 2.3-develop & pull request is #20488

@rogyar
Copy link
Contributor

rogyar commented Jan 28, 2019

Hi @amol2jcommerce. We need to wait until the original PR is merged to 2.3-develop branch. The original PR is still in review.

@amol2jcommerce
Copy link
Contributor Author

Hi @rogyar @magento-engcom-team please review.

@amol2jcommerce
Copy link
Contributor Author

@magento-engcom-team please review.

@amol2jcommerce
Copy link
Contributor Author

@magento-engcom-team please review

@rogyar rogyar self-assigned this Feb 5, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4133 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 8, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants