Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport]Sorting by Websites not working in product grid in backoffice #20514

Closed
wants to merge 1 commit into from
Closed

[Backport]Sorting by Websites not working in product grid in backoffice #20514

wants to merge 1 commit into from

Conversation

XxXgeoXxX
Copy link
Member

Issue #20511

Description (*)

Preconditions (*)

Magento Version : CE 2.2X
Magento Version : CE 2.3.X

Steps to reproduce (*)

Navigate to admin catalog product grid
Using "Columns" selection add Websites'' column in the grid

Expected result (*)

Sort by 'Websites' should be working fine.

Actual result (*)

Sort by 'websites' product attribute not working.

Fixed Issues (if relevant)

Backport for #20512

Manual testing scenarios (*)

Navigate to admin catalog product grid
Using "Columns" selection add Websites'' column in the grid

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @XxXgeoXxX. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Catalog Release Line: 2.2 Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Jan 23, 2019
@XxXgeoXxX
Copy link
Member Author

@magento-engcom-team give me 2.2.2 instance

@magento-engcom-team
Copy link
Contributor

Hi @XxXgeoXxX. Thank you for your request. I'm working on Magento 2.2.2 instance for you

rogyar
rogyar requested changes Mar 22, 2019
View reviewed changes
app/code/Magento/Catalog/Ui/Component/Listing/Columns/Websites.php
* @param array $components
* @param array $data
*/
public function __construct(
ContextInterface $context,
UiComponentFactory $uiComponentFactory,
StoreManagerInterface $storeManager,
Helper $resourceHelper,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, do not change arguments order. This change goes against backward compatibility. Add the resourceHelper to the very end of the arguments set

@ghost ghost assigned rogyar Mar 22, 2019
@sidolov
Copy link
Contributor

sidolov commented Apr 5, 2019

@XxXgeoXxX , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Apr 5, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 5, 2019

Hi @XxXgeoXxX, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@XxXgeoXxX XxXgeoXxX reopened this Apr 12, 2019
@ghost ghost unassigned rogyar Apr 12, 2019
@sidolov
Copy link
Contributor

sidolov commented Apr 29, 2019

@XxXgeoXxX , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Apr 29, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 29, 2019

Hi @XxXgeoXxX, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar requested changes

Assignees
No one assigned
Labels
Component: Catalog Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: needs update Release Line: 2.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XxXgeoXxX @magento-engcom-team @sidolov @rogyar