Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorting by Websites not working in product grid in backoffice #20511 #20512

Merged
merged 11 commits into from
Mar 16, 2019
Merged

Sorting by Websites not working in product grid in backoffice #20511 #20512

merged 11 commits into from
Mar 16, 2019

Conversation

XxXgeoXxX
Copy link
Member

issue #20511

Description (*)

Preconditions (*)

Magento Version : CE 2.2X
Magento Version : CE 2.3.X

Steps to reproduce (*)

Navigate to admin catalog product grid
Using "Columns" selection add Websites'' column in the grid

Expected result (*)

Sort by 'Websites' should be working fine.

Actual result (*)

Sort by 'websites' product attribute not working.

Manual testing scenarios (*)

Navigate to admin catalog product grid
Using "Columns" selection add Websites'' column in the grid

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @XxXgeoXxX. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Catalog Release Line: 2.3 Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Jan 23, 2019
@XxXgeoXxX XxXgeoXxX mentioned this pull request Jan 23, 2019
Closed
4 tasks
@vpodorozh vpodorozh self-requested a review February 12, 2019 07:05
@vpodorozh
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @vpodorozh. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @vpodorozh, here is your new Magento instance.
Admin access: https://pr-20512.instances.magento-community.engineering/admin
Login: admin Password: 123123q

vpodorozh
vpodorozh suggested changes Feb 13, 2019
View reviewed changes
Copy link
Contributor

@vpodorozh vpodorozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XxXgeoXxX - thank you for your contribution.
Could you please take a look at my "change request"?
Also, it would be awesome if you would add the MFTF test for product grid sorting by website.
Thank you!

app/code/Magento/Catalog/Ui/Component/Listing/Columns/Websites.php Outdated Show resolved Hide resolved
app/code/Magento/Catalog/Ui/Component/Listing/Columns/Websites.php Outdated Show resolved Hide resolved
@vpodorozh
Copy link
Contributor

@XxXgeoXxX - what about MFTF test?

@vpodorozh
Copy link
Contributor

@XxXgeoXxX - what about MFTF test?

Please add it, thx!

@XxXgeoXxX
Copy link
Member Author

Hi @vpodorozh
Mftf test was created. Could you review?

@ghost ghost assigned vpodorozh Mar 1, 2019
@magento-engcom-team
Copy link
Contributor

Hi @vpodorozh, thank you for the review.
ENGCOM-4405 has been created to process this Pull Request

okolesnyk
okolesnyk suggested changes Mar 1, 2019
View reviewed changes
app/code/Magento/Catalog/Test/Mftf/Test/AdminSortingByWebsitesTest.xml Outdated
<!--Create new website -->
<actionGroup ref="AdminCreateWebsiteActionGroup" stepKey="createAdditionalWebsite">
<argument name="newWebsiteName" value="Second Website"/>
<argument name="websiteCode" value="second_website"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend to use data entity customWebsite.
It will create unique WebSite Name and WebSite code.
Arguments will look like this

<argument name="newWebsiteName" value="{{customWebsite.name}}"/>
<argument name="websiteCode" value="{{customWebsite.code}}"/>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

app/code/Magento/Catalog/Test/Mftf/Test/AdminSortingByWebsitesTest.xml Outdated
</before>
<after>
<actionGroup ref="AdminDeleteWebsiteActionGroup" stepKey="deleteTestWebsite">
<argument name="websiteName" value="Second Website"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you will use customWebsite entity, you should also specify it here: <argument name="websiteName" value="{{customWebsite.name}}"/>
And also you should specify {{customWebsite.name}} in all actions you specified 'Second Website'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@XxXgeoXxX
Copy link
Member Author

Hi @okolesnyk
Test was improved according recomandation.

@VasylShvorak VasylShvorak self-assigned this Mar 6, 2019
@VasylShvorak
Copy link
Contributor

✔️ QA passed

@okolesnyk
Copy link
Member

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @okolesnyk. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @okolesnyk, here is your Magento instance.
Admin access: https://i-20512-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@okolesnyk
Copy link
Member

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @okolesnyk. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @okolesnyk, here is your Magento instance.
Admin access: https://i-20512-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@nmalevanec nmalevanec self-assigned this Mar 12, 2019
@sivaschenko sivaschenko mentioned this pull request Mar 12, 2019
Closed
4 tasks
@magento-engcom-team magento-engcom-team mentioned this pull request Mar 16, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit c76d248 into magento:2.3-develop Mar 16, 2019
@ghost
Copy link

ghost commented Mar 16, 2019

Hi @XxXgeoXxX, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 16, 2019
@sidolov
ENGCOM-4405: Sorting by Websites not working in product grid in backo…
5376a81 
…ffice #20511 #20512
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpodorozh vpodorozh vpodorozh approved these changes

@okolesnyk okolesnyk okolesnyk approved these changes

Assignees

@nmalevanec nmalevanec

@vpodorozh vpodorozh

@VasylShvorak VasylShvorak

Labels
Award: bug fix Component: Catalog Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
6 participants
@XxXgeoXxX @magento-engcom-team @vpodorozh @VasylShvorak @okolesnyk @nmalevanec