-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #6208 Can't sort by "Websites" in the Products > Catalog list #20937
Conversation
made sorting disable for websites as it is not an attribute of product
Hi @shikhamis11. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Here I think to disable the the sorting of website field as the sorting function is handling only the product attributes in Magento\Eav\Model\Entity\Collection\abstract :addAttributeToSort() |
Hi @aleron75, thank you for the review. |
@magento-engcom-team give me test instance |
Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you |
Hi @sivaschenko, here is your new Magento instance. |
Hi @shikhamis11 please take a look at #20512 looks like it provides a better fix for the issue |
Hi @shikhamis11, thank you for your contribution! |
made sorting disable for websites as it is not an attribute of product
2nd to last column in the table of your Proudcts titled "Websites" -- clicking the column header the page grays as if it's trying to re-order, and the little down arrow icon appears on the right of the header cell... but the list never actually sorts by what Website it's associated with
Preconditions
Steps to reproduce
Actual result
Products are not sorted
Expected result
Products are sorted
Contribution checklist (*)