Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #6208 Can't sort by "Websites" in the Products > Catalog list #20937

Closed

Conversation

shikhamis11
Copy link
Member

made sorting disable for websites as it is not an attribute of product

2nd to last column in the table of your Proudcts titled "Websites" -- clicking the column header the page grays as if it's trying to re-order, and the little down arrow icon appears on the right of the header cell... but the list never actually sorts by what Website it's associated with

Preconditions

  1. Mage 2.1.0
  2. PHP7, CentOS
  3. at least two websites are created
  4. two products are created and each one is assigned to different website

Steps to reproduce

  1. go to products grid
  2. by clicking on grid's head try to sort by Websites

Actual result

Products are not sorted

Expected result

Products are sorted

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

made sorting disable for websites as it is not an attribute of product
@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@shikhamis11
Copy link
Member Author

Here I think to disable the the sorting of website field as the sorting function is handling only the product attributes in Magento\Eav\Model\Entity\Collection\abstract :addAttributeToSort()

@aleron75 aleron75 self-assigned this Feb 5, 2019
@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-4125 has been created to process this Pull Request

@sivaschenko
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, here is your new Magento instance.
Admin access: https://pr-20937.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@sivaschenko
Copy link
Member

Hi @shikhamis11 please take a look at #20512 looks like it provides a better fix for the issue

@shikhamis11 shikhamis11 deleted the 2.3-develop6208 branch March 12, 2019 15:58
@ghost
Copy link

ghost commented Mar 12, 2019

Hi @shikhamis11, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants