Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fixed-Bundle-Product-add-to-cart-button-misaligned-2.2 #20554

Conversation

amol2jcommerce
Copy link
Contributor

@amol2jcommerce amol2jcommerce commented Jan 24, 2019

Description (*)

#20193

Fixed Issues (if relevant)

  1. Bundle-Product-add-to-cart-button-misaligned-on-tab-portrait ::Bundle… #20195: Bundle Product add to cart button misaligned on tab portrait view
  2. Magento 2.2

Manual testing scenarios (*)

  1. In product detail page on "Bundle Product" click "Customize and Add to Cart" show bundle option check "add to cart" button.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Backport for: #20195

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@amol2jcommerce
Copy link
Contributor Author

Hi @magento-engcom-team please review.

@amol2jcommerce
Copy link
Contributor Author

@magento-engcom-team please review.

1 similar comment
@amol2jcommerce
Copy link
Contributor Author

@magento-engcom-team please review.

@torhoehn
Copy link
Contributor

torhoehn commented Feb 5, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @torhoehn. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @torhoehn, here is your new Magento instance.
Admin access: https://pr-20554.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @torhoehn, thank you for the review.
ENGCOM-4143 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 8, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants