Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Bundle-Product-add-to-cart-button-misaligned-on-tab-portrait ::Bundle… #20557

Conversation

irajneeshgupta
Copy link
Member

Original Pull Request

#20195
… Product add to cart button misaligned on tab portrait view.

Description (*)

Fixed Issues (if relevant)

  1. Bundle Product add to cart button misaligned on tab portrait view. #20193: Bundle Product add to cart button misaligned on tab portrait view
  2. ...

Manual testing scenarios (*)

1.In product detail page on "Bundle Product" click "Customize and Add to Cart" show bundle option check "add to cart" button.
2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

… Product add to cart button misaligned on tab portrait view.
@magento-engcom-team
Copy link
Contributor

Hi @irajneeshgupta. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@amol2jcommerce
Copy link
Contributor

Hi @irajneeshgupta
PR already created #20554

@ghost
Copy link

ghost commented Jan 24, 2019

Hi @irajneeshgupta, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@irajneeshgupta
Copy link
Member Author

@amol2jcommerce
since your backport PR is not using original commit , do not close my backport.
Thank you.

@sidolov
Copy link
Contributor

sidolov commented Jan 28, 2019

Hi @irajneeshgupta , I'm closing this PR as a duplicate for #20554 since it was created earlier.
Thank you!

@sidolov sidolov closed this Jan 28, 2019
@ghost
Copy link

ghost commented Jan 28, 2019

Hi @irajneeshgupta, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants