-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
14857: prevent cache drop for frontend caches on sitemap generation #20818
14857: prevent cache drop for frontend caches on sitemap generation #20818
Conversation
Hi @david-fuehr. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @sidolov, thank you for the review. |
magento#14857 Introduces a (dummy) cache tag for frontend in sitemap and robots generation. This prevents the default and page_cache to be dropped completely. The cache tag for full_page cache is not modified.
ed537c4
to
ebc266b
Compare
Hi @david-fuehr, thank you for your contribution! |
Description
Introduces a (dummy) cache tag for frontend in sitemap and robots generation. This prevents the
default and page_cache to be dropped completely. The cache tag for full_page cache is not
modified.
Fixed Issues (if relevant)
Manual testing scenarios (*)
debug.log
"tags":["robots_dummy"]
(redis)"tagsPattern":"((^|,)robots_1(,|$))"}
(varnish)Contribution checklist (*)