Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14857: prevent cache drop for frontend caches on sitemap generation #20818

Conversation

david-fuehr
Copy link
Contributor

Description

Introduces a (dummy) cache tag for frontend in sitemap and robots generation. This prevents the
default and page_cache to be dropped completely. The cache tag for full_page cache is not
modified.

Fixed Issues (if relevant)

  1. Sitemap generation cron job flushes entire cache #14857: Sitemap generation cron job flushes entire cache

Manual testing scenarios (*)

  1. In Magento admin go to Marketing >> Site Map
  2. watch the debug.log
  3. Generate sitemap from admin
    1. the sitemap is generated successfully
    2. cache invalidation is logged for "tags":["robots_dummy"] (redis)
    3. cache invalidation is logged for "tagsPattern":"((^|,)robots_1(,|$))"} (varnish)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @david-fuehr. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4055 has been created to process this Pull Request

magento#14857

Introduces a (dummy) cache tag for frontend in sitemap and robots generation. This prevents the
default and page_cache to be dropped completely. The cache tag for full_page cache is not
modified.
@david-fuehr david-fuehr force-pushed the issue-14857-cache-drop-sitemap branch from ed537c4 to ebc266b Compare January 31, 2019 13:08
@magento magento deleted a comment from magento-cicd2 Jan 31, 2019
@ghost
Copy link

ghost commented Mar 5, 2019

Hi @david-fuehr, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants