Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] 20818 - prevent cache drop for frontend caches on sitemap generation #21698

Merged
merged 5 commits into from
Mar 20, 2019
Merged

[Backport] 20818 - prevent cache drop for frontend caches on sitemap generation #21698

merged 5 commits into from
Mar 20, 2019

Conversation

david-fuehr
Copy link
Contributor

david-fuehr and others added 5 commits February 18, 2019 16:30
@david-fuehr
Merge branch '2.2-develop' of github.com:magento/magento2 into 2.2-de…
08a1446 
…velop
@david-fuehr
Merge branch '2.2-develop' of github.com:magento/magento2 into 2.2-de…
0992c48 
…velop
@david-fuehr
14857: prevent cache drop for frontend caches on sitemap generation
46810b0 
magento#14857

Introduces a (dummy) cache tag for frontend in sitemap and robots generation. This prevents the
default and page_cache to be dropped completely. The cache tag for full_page cache is not
modified.
@david-fuehr
amend touched DocBlocks
c5993ce
@nmalevanec @david-fuehr
Fix static tests.
a69a3d0
@magento-engcom-team
Copy link
Contributor

Hi @david-fuehr. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@david-fuehr david-fuehr changed the title Back port pull 20818 [Backport] 20818 - prevent cache drop for frontend caches on sitemap generation Mar 11, 2019
@dmytro-ch dmytro-ch self-requested a review March 12, 2019 06:55
@dmytro-ch dmytro-ch self-assigned this Mar 12, 2019
@dmytro-ch
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-21698.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4478 has been created to process this Pull Request

@VasylShvorak VasylShvorak self-assigned this Mar 18, 2019
@VasylShvorak
Copy link
Contributor

✔️ QA passed

@p-bystritsky p-bystritsky self-assigned this Mar 18, 2019
@magento-engcom-team magento-engcom-team merged commit a69a3d0 into magento:2.2-develop Mar 20, 2019
@ghost
Copy link

ghost commented Mar 20, 2019

Hi @david-fuehr, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 20, 2019
@sidolov
ENGCOM-4478: [Backport] 20818 - prevent cache drop for frontend cache…
6167719 
…s on sitemap generation #21698
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch approved these changes

Assignees

@dmytro-ch dmytro-ch

@p-bystritsky p-bystritsky

@VasylShvorak VasylShvorak

Labels
Component: Robots Component: Sitemap Partner: TechDivision partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.9
Development

Successfully merging this pull request may close these issues.
7 participants
@david-fuehr @magento-engcom-team @dmytro-ch @VasylShvorak @ihor-sviziev @p-bystritsky @nmalevanec