Missed form validation in Admin Order Address Edit route sales/order/address

[XxXgeoXxX]

Original Issue #19360

Description (*)

Magento 2.2.* and 2.3.*
EAV validation rules are not checked during editing an address in order.
route: sales/order/address
See column validate_rules in table customer_eav_attribute
e.g. name may have '{"max_text_length":255}'
Controller: \Magento\Sales\Controller\Adminhtml\Order\AddressSave::execute

This rules work in other forms on fronted and in address form and during creating new order from Admin
route: sales/order_create/index/

Note: added classes for inputs according to validation rules for attribute

Manual testing scenarios (*)

Create an order
Find the order in admin
Click edit on address section
Fill the field firstname or lastname with any characters till length be more than 255
Save address and see saved value

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @XxXgeoXxX. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[slavvka]

Hey @XxXgeoXxX Could you please consider covering your improvement with automated tests? I would suggest adding MFTF negative tests.

[XxXgeoXxX]

Hi, @slavvka
Thank you for your review and comment. I'll update my PR and add tests.

[slavvka]

Hey @XxXgeoXxX I can see you added changes. Did you run your MFTF test locally?

[XxXgeoXxX]

Hi, yes. I saw that I got merge conflict. Maybe I have not up to day branch. I will resolve it.

[XxXgeoXxX]

@slavvka
merge conflict was resolved. could you check?

[magento-engcom-team]

Hi @slavvka, thank you for the review.
ENGCOM-4238 has been created to process this Pull Request

[ghost]

Hi @XxXgeoXxX, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.