Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Missed form validation in Admin Order Address Edit route sales/order/address #20841

Closed
wants to merge 4 commits into from

Conversation

XxXgeoXxX
Copy link
Member

Original issue
#19360

Description (*)

Magento 2.2.* and 2.3.*
EAV validation rules are not checked during editing an address in order.
route: sales/order/address
See column validate_rules in table customer_eav_attribute
e.g. name may have '{"max_text_length":255}'
Controller: \Magento\Sales\Controller\Adminhtml\Order\AddressSave::execute

This rules work in other forms on fronted and in address form and during creating new order from Admin
route: sales/order_create/index/

Note: added classes for inputs according to validation rules for attribute

Fixed Issues (if relevant)

Original PR: #20840

Manual testing scenarios (*)

Create an order
Find the order in admin
Click edit on address section
Fill the field firstname or lastname with any characters till length be more than 255
Save address and see saved value

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @XxXgeoXxX. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Sales Release Line: 2.2 Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Jan 31, 2019
@slavvka slavvka self-assigned this Jan 31, 2019
@orlangur orlangur self-assigned this Apr 5, 2019
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XxXgeoXxX please rewrite branch history so that it matches https://github.com/magento/magento2/pull/20840/commits.

@sidolov
Copy link
Contributor

sidolov commented Apr 19, 2019

@XxXgeoXxX , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Apr 19, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 19, 2019

Hi @XxXgeoXxX, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Sales Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: needs update Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants