Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unwanted condition check #21046

Merged
merged 2 commits into from
Feb 19, 2019
Merged

Remove unwanted condition check #21046

merged 2 commits into from
Feb 19, 2019

Conversation

dominicfernando
Copy link
Contributor

@dominicfernando dominicfernando commented Feb 7, 2019

Version: 2.3-develop
OS - Ubuntu 18.04

Description (*)

Removed unwanted condition check. This check is not needed, Because always create a new instance

Manual testing scenarios (*)

  1. Create "CMS Page" with "CMS Page Link" widget and browse in the frontend

selection_014

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @dominicfernando. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Cms Release Line: 2.3 Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Feb 7, 2019
@VladimirZaets VladimirZaets self-assigned this Feb 7, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-4177 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 10fc55b into magento:2.3-develop Feb 19, 2019
@ghost
Copy link

ghost commented Feb 19, 2019

Hi @dominicfernando, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Feb 19, 2019
nainesh2jcommerce pushed a commit to nainesh2jcommerce/magento2 that referenced this pull request Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Component: Cms Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants