Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport]fixes-for-#21046-2-2 #21318

Conversation

nainesh2jcommerce
Copy link
Contributor

@nainesh2jcommerce nainesh2jcommerce commented Feb 19, 2019

Original Pull Request

#21046

Description (*)

Removed unwanted condition check. This check is not needed, Because always create a new instance

Manual testing scenarios (*)

  1. Create "CMS Page" with "CMS Page Link" widget and browse in the frontend
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @nainesh2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@nainesh2jcommerce nainesh2jcommerce changed the title fixes-for-#21046-2-2 [Backport]fixes-for-#21046-2-2 Feb 19, 2019
@dmytro-ch dmytro-ch self-requested a review February 19, 2019 06:19
@dmytro-ch dmytro-ch self-assigned this Feb 19, 2019
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4314 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 19, 2019

Hi @nainesh2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dmytro-ch dmytro-ch reopened this Feb 19, 2019
@dmytro-ch
Copy link
Contributor

@abrarpathan19, why did you close the PR from another developer?
This PR is already approved.

@abrarpathan19
Copy link
Contributor

@dmytro-ch I am the author of this PR so I have the priority to backport my issue first.

@sivaschenko
Copy link
Member

sivaschenko commented Feb 21, 2019

Hi @nainesh2jcommerce , thanks for the backport!

However, the original pull request is marked as a cleanup. We cannot accept cleanup pull requests to 2.2-develop.

See Contribution Guide for details.

@ghost
Copy link

ghost commented Feb 21, 2019

Hi @nainesh2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants