-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport]fixes-for-#21046-2-2 #21318
[Backport]fixes-for-#21046-2-2 #21318
Conversation
Hi @nainesh2jcommerce. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @dmytro-ch, thank you for the review. |
Hi @nainesh2jcommerce, thank you for your contribution! |
@abrarpathan19, why did you close the PR from another developer? |
@dmytro-ch I am the author of this PR so I have the priority to backport my issue first. |
Hi @nainesh2jcommerce , thanks for the backport! However, the original pull request is marked as a cleanup. We cannot accept cleanup pull requests to 2.2-develop. See Contribution Guide for details. |
Hi @nainesh2jcommerce, thank you for your contribution! |
Original Pull Request
#21046
Description (*)
Removed unwanted condition check. This check is not needed, Because always create a new instance
Manual testing scenarios (*)
Contribution checklist (*)