Remove Environment emulation for better performance on sitemap generation

[Nazar65]

Description (*)

We dont need to use Environment emulation we just need to add in

magento2/app/code/Magento/Sitemap/Model/ResourceModel/Catalog/Product.php

Line 390 in a5330a7

protected function _loadProductImages($product, $storeId)

this $this->_storeManager->setCurrentStore($storeId);

Fixed Issues (if relevant)

1. magento/magento2#<issue_number>: Issue title
2. ...

Manual testing scenarios (*)

Website URL 1: https://my_website.com
Website URL 2: https://my_website.co.uk

Got to Stores->Configuration->Catalog->XML Sitemap->General Settings:
2.Set to Enable, Start Time, Frequency Daily etc...
TIP: I've set to a few minutes before checking!

Website 1 should have images url referencing Website 1 domain = https://my_website.com

1.2 - Same steps for manual generating sitemap

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[orlangur]

Seems to be a reworked version of #16813 and https://github.com/magento/magento2/pull/19598/files. Could you please remove unneeded dependencies then?

@sidolov @sivaschenko would be really nice if you change the logic as you reviewed older PR.

[Nazar65]

@orlangur Thanks, for some reason i forgot for this.

[sivaschenko]

Hi @Nazar65 thanks for the pull request. The functionality looks fine, however, I don't think we can remove the arguments from construction at this time for backward compatibility purpose. Can you please preserve constructor signatures

[orlangur]

@sivaschenko not really. We cannot change released class signature (@Nazar65 please revert those) but we are free to change the 2.3.2 targeted PR.

[magento-engcom-team]

Hi @sivaschenko, thank you for the review.
ENGCOM-4438 has been created to process this Pull Request

[orlangur]

@Nazar65 unneeded dependency introduced in https://github.com/magento/magento2/pull/19598/files must be removed.

Please squash into single commit after change.

[Nazar65]

@orlangur ok

[Nazar65]

@orlangur done ✔️

[sivaschenko]

@orlangur I see what you mean, yes, those changes are not included in 2.3.1 👍

[magento-engcom-team]

Hi @orlangur, thank you for the review.
ENGCOM-4438 has been created to process this Pull Request

[fooman]

Judging by the manual testing steps this is currently using English as a language only. Emulation also sets different locales, reloads translations and switches the area. This all seems to be removed in this PR.

[Nazar65]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @Nazar65. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @Nazar65, here is your new Magento instance.
Admin access: https://pr-21542.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[Nazar65]

@fooman No, everything works as expected from manual steps, and this works perfect on 2.2.7 without emulation.

[soleksii]

✔️ QA Passed

[sidolov]

Hi @Nazar65 , looks like these changes were introduced to fix the bug with sitemap generation in scope of #15689. Could you please verify that initial case not reproducing with provided changes?
Thank you!

[Nazar65]

@sidolov Yes, initial case not reproducing with provided changes

[ghost]

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.