Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fix gallery full-screen triggers #21918

Merged

Conversation

iGerchak
Copy link
Contributor

@iGerchak iGerchak commented Mar 25, 2019

Original Pull Request

#21919

Preconditions

  1. Magento 2.2.7

Description (*)

We find the issue when tried to select some text or value in the text field on the product page.
When you press mouse on the text and move mouse left up to the image gallery then make mouse up, on the image, it triggers full-screen gallery opening.

Steps to reproduce:

  1. Go to product page
  2. Press mouse on the text (product description) and move mouse left up to the image gallery
  3. Make mouse up on the big gallery image

Expected result

No full-screen gallery. Just selected text.

Actual result

Full-screen gallery.

@magento-engcom-team
Copy link
Contributor

Hi @iGerchak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@iGerchak iGerchak changed the title Fix triggers gallery full-screen Fix gallery full-screen triggers Mar 25, 2019
@ihor-sviziev
Copy link
Contributor

Hi @iGerchak,
Please create PR with the same changes to 2.3-develop at first

@ihor-sviziev ihor-sviziev self-assigned this Mar 25, 2019
@ihor-sviziev ihor-sviziev changed the title Fix gallery full-screen triggers [Backport] Fix gallery full-screen triggers Mar 25, 2019
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-4565 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@ghost
Copy link

ghost commented Mar 27, 2019

Hi @iGerchak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants