Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fix gallery event observer #22250

Merged
merged 1 commit into from
Apr 17, 2019

Conversation

Den4ik
Copy link
Contributor

@Den4ik Den4ik commented Apr 9, 2019

Original PR

#21790

Description (*)

This PR fix issue of opening gallery if moving mouse to image when clicking to another element of page

Fixed Issues (if relevant)

  1. [BUG] Product gallery opening by mistake #21789: [BUG] Product gallery opening by mistake

Manual testing scenarios (*)

  1. Open product page
  2. Click to product qty move cursor to product image and up mouse button

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 9, 2019

Hi @Den4ik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@Den4ik Den4ik changed the title [BACKPORT] Fix gallery event observer [Backport] Fix gallery event observer Apr 9, 2019
@Karlasa Karlasa self-assigned this Apr 9, 2019
@Karlasa
Copy link
Contributor

Karlasa commented Apr 9, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, here is your new Magento instance.
Admin access: https://pr-22250.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, thank you for the review.
ENGCOM-4720 has been created to process this Pull Request

@VasylShvorak VasylShvorak self-assigned this Apr 10, 2019
@VasylShvorak
Copy link
Contributor

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @VasylShvorak. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @VasylShvorak, here is your Magento instance.
Admin access: https://i-22250-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@VasylShvorak
Copy link
Contributor

Hi @Den4ik I cannot reproduce issue #21789 on 2.2-develop

@Karlasa
Copy link
Contributor

Karlasa commented Apr 10, 2019

@VasylShvorak
you are correct. Looks like this issue was already fixed at the end of the last month. If you check the history

https://github.com/magento/magento2/commits/66bacdb4129b0fc7beff62f517d06fe8b4e623b7/lib/web/mage/gallery/gallery.js

commit : ENGCOM-4565: [Backport] Fix gallery full-screen triggers #21918

Will close this PR.

@Karlasa Karlasa closed this Apr 10, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 10, 2019

Hi @Den4ik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@Den4ik
Copy link
Contributor Author

Den4ik commented Apr 10, 2019

@Karlasa yep,
but are you sure that we should to have different versions on 2.3 and 2.2?

@Den4ik
Copy link
Contributor Author

Den4ik commented Apr 10, 2019

@Karlasa Also I think that organisation of checking of PR is not good. My PR was opened 25 days ago, merged later #21918

@Den4ik
Copy link
Contributor Author

Den4ik commented Apr 10, 2019

@magento-engcom-team in my opinion we should to have same version in both branches

@Den4ik Den4ik reopened this Apr 10, 2019
@ghost ghost unassigned Karlasa and VasylShvorak Apr 10, 2019
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VasylShvorak please just make sure #21789 and #21919 and other related scenarios are working after the fix.

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4734 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Apr 17, 2019

Hi @Den4ik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Apr 17, 2019
@Den4ik Den4ik deleted the pr-port-21790 branch May 22, 2019 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants