-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] Fix gallery event observer #22250
Conversation
Hi @Den4ik. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@magento-engcom-team give me test instance |
Hi @Karlasa. Thank you for your request. I'm working on Magento instance for you |
Hi @Karlasa, here is your new Magento instance. |
Hi @Karlasa, thank you for the review. |
@magento-engcom-team give me 2.2-develop instance |
Hi @VasylShvorak. Thank you for your request. I'm working on Magento 2.2-develop instance for you |
Hi @VasylShvorak, here is your Magento instance. |
@VasylShvorak commit : ENGCOM-4565: [Backport] Fix gallery full-screen triggers #21918 Will close this PR. |
Hi @Den4ik, thank you for your contribution! |
@Karlasa yep, |
@magento-engcom-team in my opinion we should to have same version in both branches |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VasylShvorak please just make sure #21789 and #21919 and other related scenarios are working after the fix.
Hi @orlangur, thank you for the review. |
✔️ QA passed |
Hi @Den4ik, thank you for your contribution! |
Original PR
#21790
Description (*)
This PR fix issue of opening gallery if moving mouse to image when clicking to another element of page
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)