Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove timestap from current date when saving product special price from date #21966

Conversation

JeroenVanLeusden
Copy link
Member

@JeroenVanLeusden JeroenVanLeusden commented Mar 27, 2019

Description (*)

Full timestamp is saved when creating a new product with a special price but without a special price from value.

With this fix, the time is reset so only the date will be saved. This is also in line with the UI where only a date can be selected.

Fixed Issues (if relevant)

  1. None I could find.

Manual testing scenarios (*)

  1. Set configuration on global scope general/locale/timezone > Europe/Amsterdam.
  2. Set configuration on en_US scope general/locale/timezone > America/New_York.
  3. Create new simple product with special price (leave special price from date empty).
  4. Product will be saved with a current timestamp using the Europe/Amsterdam timezone.
  5. Navigate to product on frontend (en_US store), no special price is shown. This is because special price from date is checked against the America/New_York timezone. This isn't the case for another five hours.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @JeroenVanLeusden. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4599 has been created to process this Pull Request

@soleksii
Copy link

soleksii commented Apr 3, 2019

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Apr 8, 2019

Hi @JeroenVanLeusden, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants