[Backport] Remove timestap from current date when saving product special price from date

[krishprakash]

Original Pull Request

#21966

Description (*)

Full timestamp is saved when creating a new product with a special price but without a special price from value.

With this fix, the time is reset so only the date will be saved. This is also in line with the UI where only a date can be selected.

Fixed Issues (if relevant)

1. None I could find.

Manual testing scenarios (*)

1. Set configuration on global scope general/locale/timezone > Europe/Amsterdam.
2. Set configuration on en_US scope general/locale/timezone > America/New_York.
3. Create new simple product with special price (leave special price from date empty).
4. Product will be saved with a current timestamp using the Europe/Amsterdam timezone.
5. Navigate to product on frontend (en_US store), no special price is shown. This is because special price from date is checked against the America/New_York timezone. This isn't the case for another five hours.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[m2-assistant]

Hi @krishprakash. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[orlangur]

@krishprakash original commit author must be preserved

[magento-cicd2]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

Prakash Prajapati seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

[krishprakash]

@orlangur I have updated the PR as suggested by you.
Please have a look and update the PR.
Thank you.

[orlangur]

@krishprakash please sign CLA.

[krishprakash]

@krishprakash please sign CLA.

@orlangur Signed the CLA.

[ghost]

@krishprakash unfortunately, only members of the maintainers team are allowed to remove progress related labels to the pull request

[krishprakash]

@orlangur
Is there anything remaining from my end ?
If any please let me know.
Otherwise please update the status of PR.
Thanks.

[magento-engcom-team]

Hi @orlangur, thank you for the review.
ENGCOM-5341 has been created to process this Pull Request
✳️ @orlangur, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Alfa]

✔️ QA Passed

[m2-assistant]

Hi @krishprakash, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.