-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#22047 Feature: Newrelic transaction name based on CLI name #22059
Merged
magento-engcom-team
merged 5 commits into
magento:2.3-develop
from
lbajsarowicz:feature/newrelic-cli-transaction-name
Apr 26, 2019
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a1661a5
#22047 Add Transaction name to NewRelic based on Command name
lbajsarowicz 07f8a65
Remove unused `use` section
lbajsarowicz 638b73a
Cleanup for Wrapper
lbajsarowicz bb861cc
Merge remote-tracking branch 'mainline/2.3-develop' into feature/newr…
nmalevanec 9cd00fa
Fix static tests.
nmalevanec File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
app/code/Magento/NewRelicReporting/Plugin/CommandPlugin.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
<?php | ||
/** | ||
* Copyright © Magento, Inc. All rights reserved. | ||
* See COPYING.txt for license details. | ||
*/ | ||
|
||
namespace Magento\NewRelicReporting\Plugin; | ||
|
||
use Magento\NewRelicReporting\Model\Config; | ||
use Magento\NewRelicReporting\Model\NewRelicWrapper; | ||
use Symfony\Component\Console\Command\Command; | ||
|
||
/** | ||
* Describe NewRelic commands plugin. | ||
*/ | ||
class CommandPlugin | ||
{ | ||
/** | ||
* @var Config | ||
*/ | ||
private $config; | ||
|
||
/** | ||
* @var NewRelicWrapper | ||
*/ | ||
private $newRelicWrapper; | ||
|
||
/** | ||
* @param Config $config | ||
* @param NewRelicWrapper $newRelicWrapper | ||
*/ | ||
public function __construct( | ||
Config $config, | ||
NewRelicWrapper $newRelicWrapper | ||
) { | ||
$this->config = $config; | ||
$this->newRelicWrapper = $newRelicWrapper; | ||
} | ||
|
||
/** | ||
* Set NewRelic Transaction name before running command. | ||
* | ||
* @param Command $command | ||
* @param array $args | ||
* @return array | ||
*/ | ||
public function beforeRun(Command $command, ...$args) | ||
{ | ||
$this->newRelicWrapper->setTransactionName( | ||
sprintf('CLI %s', $command->getName()) | ||
); | ||
|
||
return $args; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a public function is a backward incompatible change, however, this class is not public (not marked with
@api
tag)