-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#22047 Feature: Newrelic transaction name based on CLI name #22059
#22047 Feature: Newrelic transaction name based on CLI name #22059
Conversation
Hi @lbajsarowicz. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
* @param string $transactionName | ||
* @return void | ||
*/ | ||
public function setTransactionName(string $transactionName): void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a public function is a backward incompatible change, however, this class is not public (not marked with @api
tag)
Hi @sivaschenko, thank you for the review. |
…elic-cli-transaction-name
Hi @lbajsarowicz, thank you for your contribution! |
Release note for version 2.3.x: New Relic Reporting: Magento 2 CLI command names are now reported in the transaction names in the New Relic APM Monitoring Data. The transaction name is based on the Magento CLI command name, for example |
@meker12 Not "Magento 2 cron job names" but "Magento 2 CLI command names" to be precise (!) |
@lbajsarowicz Thanks so much for the feedback 🥇 |
Description (*)
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)