Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#22047 Feature: Newrelic transaction name based on CLI name #22059

Merged
merged 5 commits into from
Apr 26, 2019
Merged

#22047 Feature: Newrelic transaction name based on CLI name #22059

merged 5 commits into from
Apr 26, 2019

Conversation

lbajsarowicz
Copy link
Contributor

Description (*)

Screenshot 2019-03-30 at 13 51 23

Fixed Issues (if relevant)

  1. Magento CRON Job Names are missing in NewRelic: "Transaction Names" #22047: Magento CRON Job Names are missing in NewRelic: "Transaction Names"

Manual testing scenarios (*)

  1. Configure your Newrelic setup
  2. Run any CLI command
  3. Check transaction list

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 30, 2019

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

* @param string $transactionName
* @return void
*/
public function setTransactionName(string $transactionName): void
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a public function is a backward incompatible change, however, this class is not public (not marked with @api tag)

@ghost ghost assigned sivaschenko Apr 1, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-4634 has been created to process this Pull Request

@m2-assistant
Copy link

m2-assistant bot commented Apr 26, 2019

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@meker12
Copy link
Contributor

meker12 commented May 28, 2019

Release note for version 2.3.x:

New Relic Reporting:

Magento 2 CLI command names are now reported in the transaction names in the New Relic APM Monitoring Data. The transaction name is based on the Magento CLI command name, for example cli app:config:import, cli indexer:reindex, and cli cache:flush. In previous releases, the New Relic transaction names for CLI commands initiated by Magento 2 cron jobs was missing and reported as unknown.

@lbajsarowicz
Copy link
Contributor Author

@meker12 Not "Magento 2 cron job names" but "Magento 2 CLI command names" to be precise (!)

@meker12
Copy link
Contributor

meker12 commented May 28, 2019

@lbajsarowicz Thanks so much for the feedback 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants